Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61307 )
Change subject: console: Add ANSI escape sequences for highlighting ......................................................................
Patch Set 8:
(1 comment)
File src/console/Kconfig:
https://review.coreboot.org/c/coreboot/+/61307/comment/21c14311_dc90779c PS8, Line 400: default y
Out of curiosity, is there a specific reason to enable this option by default instead of using site- […]
I was just trying to guess what would be the preferred option for most users. I understand that there may be some use cases where this is annoying, but on the other side if it is off by default most users would probably never discover it in the first place. I would assume that we have a lot more developers reading their UART in a terminal window than those who pipe it into a file, but if you disagree I don't know what's the best way to find out for sure... maybe we should hold a poll on the mailing list or something?
Of course, for use cases where this is causing issues it's easy to disable (that's why I made it a separate Kconfig). The tokens are also easy to strip out after the fact, e.g. by piping through `sed -e "s/\x1b[[^m]{1,9}m//g"`.