Attention is currently required from: Felix Held, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Martin Roth, Paul Menzel, Simon Glass, Simon Glass.
Arthur Heymans has posted comments on this change by Simon Glass. ( https://review.coreboot.org/c/coreboot/+/77712?usp=email )
Change subject: Introduce a coreboot Control Block (CCB)
......................................................................
Patch Set 13:
(2 comments)
Patchset:
PS13:
ra
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/77712/comment/b74d8c97_f8c0f473?usp... :
PS13, Line 730: cbfs_ccb_set_value
Search for "bootblock.bin" in makefiles. This would get you a list of all the platforms for which this approach would be broken. The same can be said of RoT technologies. Making post build updatable configuration part of the binary is not a scalable approach in my estimation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77712?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04e946b33035a493e833500351a0483761252613
Gerrit-Change-Number: 77712
Gerrit-PatchSet: 13
Gerrit-Owner: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Simon Glass
sjg@chromium.org
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 03 Jul 2024 08:30:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No