Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59854 )
Change subject: soc/intel/alderlake: Define soc_get_pcie_rp_type
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/pcie_rp.c:
https://review.coreboot.org/c/coreboot/+/59854/comment/ace3751b_79e9747e
PS1, Line 64: if (is_part_of_group(dev, cpu_rp_groups))
@Tim, just a point for discussion, ADL-N doesn't have CPU RPs hence should it be like this ?
if (CONFIG_MAX_CPU_ROOT_PORTS)
if (is_part_of_group(dev, cpu_rp_groups))
return PCIE_RP_CPU;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59854
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7438513e10b7cea8dac678b97a901b710247c188
Gerrit-Change-Number: 59854
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 03 Dec 2021 06:05:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment