12 Oct
2021
12 Oct
'21
8:12 a.m.
Attention is currently required from: Raul Rangel, Martin Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57782 )
Change subject: mb/google/guybrush: enable ACPIMMIO decode in mb_set_up_early_espi ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/bootblock.c:
https://review.coreboot.org/c/coreboot/+/57782/comment/53af72ed_ee476478 PS1, Line 30: enable_acpimmio_decode_pm04
I like the callback idea.
CB:58114 with the comment i added there should properly solve this issue and make this patch obsolete. or maybe take over the change id of this one for the enable_acpimmio_decode_pm04 move i lined out there?
--
To view, visit https://review.coreboot.org/c/coreboot/+/57782
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bc076261c72cf999a5f2464b74cff6bf694d473
Gerrit-Change-Number: 57782
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Comment-Date: Mon, 11 Oct 2021 21:12:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Martin Roth martinroth@google.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment