Attention is currently required from: Jason Glenesk, Tim Van Patten, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74378 )
Change subject: vc/amd/fsp/phoenix/platform_descriptors: add PCIe gen 4 link speed
......................................................................
Patch Set 1: -Code-Review
(1 comment)
File src/vendorcode/amd/fsp/phoenix/platform_descriptors.h:
https://review.coreboot.org/c/coreboot/+/74378/comment/2e66b59e_7a562cac
PS1, Line 194: uint32_t link_speed_capability :2; // See dxio_link_speed_cap
using GEN4 enum value overflows this field
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74378
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74f0b79e336206113ade24a87cbd161a12967f56
Gerrit-Change-Number: 74378
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Van Patten
timvp@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 14 Apr 2023 12:31:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment