Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31557 )
Change subject: rtc: Fix rtc_calc_weekday ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/#/c/31557/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31557/10//COMMIT_MSG@12 PS10, Line 12:
Please give the date, for which an incorrect weekday was calculated, so that both implementation can […]
Sure! Today, February 26, 2019. I get Wednesday running the old algorithm, and Tuesday for Zeller's rule.
https://review.coreboot.org/#/c/31557/10/src/lib/rtc.c File src/lib/rtc.c:
https://review.coreboot.org/#/c/31557/10/src/lib/rtc.c@120 PS10, Line 120:
nit: Please no space after casts
Done
https://review.coreboot.org/#/c/31557/10/src/lib/rtc.c@135 PS10, Line 135: "Time: %2d:%02d:%02d\n",
nit: I don't think this line needs to be broken anymore?
Done