Attention is currently required from: Xi Chen, Paul Menzel, Xixi Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61334 )
Change subject: soc/mediatek: Pass dram info to cbmem ......................................................................
Patch Set 18:
(3 comments)
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/61334/comment/73c01d9a_04eec87c PS16, Line 111: mem_chip channel array: 2
Let's wait for the discussion on CB:59193.
Ack
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/61334/comment/76cdfd04_c6d2441e PS18, Line 110: MEM_CHIP_LPDDR4 MEM_CHIP_LPDDR4X (and remove comment)
CB:59193 is merged. Please rebase.
File src/soc/mediatek/mt8186/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/61334/comment/3c597a64_50742faf PS18, Line 74: CPPFLAGS_common += -Isrc/commonlib/bsd/include/commonlib/bsd Why do we need this? Can't we just include <commonlib/bsd/mem_chip_info.h> in memory.c?