Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36143 )
Change subject: arch/x86/boot.c: Pass arguments when running programs
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36143/3/src/arch/x86/boot.c
File src/arch/x86/boot.c:
https://review.coreboot.org/c/coreboot/+/36143/3/src/arch/x86/boot.c@34
PS3, Line 34: asmlinkage
I requested this thinking about x86-32. However, I'm not sure what this decoration does when compiling for x86-64. Arthur, what's the disassembly look like with that change?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0f44e9e1992221e02c49d0492cdd2a3d9013560
Gerrit-Change-Number: 36143
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 25 Oct 2019 19:46:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment