Attention is currently required from: Angel Pons, Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/67495?usp=email )
Change subject: gma tgl: Fill out power and clocks module
......................................................................
Patch Set 34:
(1 comment)
File common/tigerlake/hw-gfx-gma-power_and_clocks.adb:
https://review.coreboot.org/c/libgfxinit/+/67495/comment/fa1306b2_74601fa1 :
PS32, Line 499: when 19_200_000 => PLL_Ratio := Ratio_For_19_2_Mhz (CDClk);
: when 38_400_000 => PLL_Ratio := Ratio_For_19_2_MHz (CDClk) / 2;
: when 24_000_000 => PLL_Ratio := Ratio_For_24_Mhz (CDClk);
nit: `MHz` case is inconsistent
Done
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/67495?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I8f09696588aa73cebc7a44583ae5e029c705a535
Gerrit-Change-Number: 67495
Gerrit-PatchSet: 34
Gerrit-Owner: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Dinesh Gehlot
digehlot@google.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 23 Apr 2024 21:34:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment