Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33141 )
Change subject: mb/*/{x201,ms2290}/mainboard.c: Remove superfluous ramstage code
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Looks rather good
https://review.coreboot.org/c/coreboot/+/33141/2/src/mainboard/lenovo/x201/m...
File src/mainboard/lenovo/x201/mainboard.c:
https://review.coreboot.org/c/coreboot/+/33141/2/src/mainboard/lenovo/x201/m...
PS2, Line 81:
:
:
:
Done in the romstage
Done
https://review.coreboot.org/c/coreboot/+/33141/3/src/mainboard/lenovo/x201/m...
File src/mainboard/lenovo/x201/mainboard.c:
https://review.coreboot.org/c/coreboot/+/33141/3/src/mainboard/lenovo/x201/m...
PS3, Line 68: u16 pmbase;
Unused
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0270c50dea2a2ce6c8e6114ed708f06be9d33c0e
Gerrit-Change-Number: 33141
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Tue, 13 Aug 2019 11:25:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment