Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37855 )
Change subject: mb/**/dsdt.asl: Remove outdated sleepstates.asl comment
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
I read this comment as:
"We are now including a chipset specific file from mainboard context."
How was it changed so that this comment is not true anymore? The include still targets a file in the chipset (southbridge or soc) domain. I just must oversee something.
I understand this comment as "include chipset-specific sleep states". To me, this sounds as if sleep state definitions vary from chipset to chipset, which is no longer the case (they are common to all intel southbridges). Also, half of the comment just repeats the filename, which is somewhat redundant.
Also, note that there are two exceptions: facebook/fbg1701 and portwell/m107. These boards have their own definition of sleepstates, so the comment is updated instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37855
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50aba6e74f41e2fa498375b5eb6b7e993d06bcac
Gerrit-Change-Number: 37855
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 23 Dec 2019 20:58:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment