Attention is currently required from: Paul Menzel, Subrata Banik, Angel Pons, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56650 )
Change subject: soc/intel/common: Don't suppress SPD Module Type value ......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/smbios.c:
https://review.coreboot.org/c/coreboot/+/56650/comment/cb91dcb6_4210c12b PS3, Line 18: /* Translate to DDR2 module type field that SMBIOS code expects. */ Subrata, I think we need to address the root problem here. Why does the SMBIOS code expect module type in DDR2 format? We are always going to run into issues trying to fit module types for new memory technologies into the values supported by DDR2.
Instead, I think we need to separate this out such that:
1. mod_type contains the value of module type for the given memory type. 2. In `create_smbios_type17_for_dimm()`, use both mod_type and ddr_type to determine the correct translation from mod_type to smbios form factor. I think we are going to need at least the following 3 conversions: ``` * ddr3 * ddr4 * lp -- I have not checked if LP3 and LP4/LP4x use the same module types. If not, then those will have to be separate as well. ```