Attention is currently required from: Alper Nebi Yasak, Martin L Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80368?usp=email )
Change subject: mb/qemu/fw_cfg: Move fw_cfg driver to drivers/emulation/qemu ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Instead of moving things to src/mb/emulation/qemu and src/include, maybe create src/mb/emulation/qem […]
The header files could also be included with their full path, e.g. ``` #include <mainboard/emulation/qemu_common/fw_cfg.h> ``` or ``` #include <drivers/emulation/qemu/fw_cfg.h> ``` That's sometimes more convenient than adding a directory for only a few files.
File src/drivers/emulation/qemu/Kconfig:
https://review.coreboot.org/c/coreboot/+/80368/comment/dc03c442_63c8d7cd : PS1, Line 29: bool "QEMU firmware configuration driver"
So just use `bool` instead of `bool "prompt"` - that way it won't show up as user configurable.
Yes, thanks for eloborating.