[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Generate ACPI pstate and cstate objects in cb

[Jason Glenesk (Code Review)]

Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45340 )

Change subject: soc/amd/picasso: Generate ACPI pstate and cstate objects in cb
......................................................................

Patch Set 24:

(4 comments)

https://review.coreboot.org/c/coreboot/+/45340/19/src/soc/amd/picasso/acpi.c 
File src/soc/amd/picasso/acpi.c:

https://review.coreboot.org/c/coreboot/+/45340/19/src/soc/amd/picasso/acpi.c... 
PS19, Line 186: 200 * core_freq_mul) / (core_freq_div
> I can do that. […]

Done

https://review.coreboot.org/c/coreboot/+/45340/22/src/soc/amd/picasso/acpi.c 
File src/soc/amd/picasso/acpi.c:

https://review.coreboot.org/c/coreboot/+/45340/22/src/soc/amd/picasso/acpi.c... 
PS22, Line 184: core_freq
> Yea

Done

https://review.coreboot.org/c/coreboot/+/45340/22/src/soc/amd/picasso/acpi.c... 
PS22, Line 234: current_value
> Will do.

Done

https://review.coreboot.org/c/coreboot/+/45340/22/src/soc/amd/picasso/acpi.c... 
PS22, Line 305: static
> Definitely not. […]

Done