Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32553 )
Change subject: soc/intel/skylake: Remove redundent mca_configure() in ramstage
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32553/1/src/soc/intel/skylake/finalize.c
File src/soc/intel/skylake/finalize.c:
https://review.coreboot.org/#/c/32553/1/src/soc/intel/skylake/finalize.c@a14...
PS1, Line 146:
Do we know why this change was added here? It seems like we should revert both these CLs: […]
i don't see any crossbug and any details about failure in commit msg, i have added Pratik to share his view.
but, you point is valid that if we decide to revert then we should revert those 2 in series.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32553
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e54fd07816c6317588ab6db06365937c4300ccd
Gerrit-Change-Number: 32553
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 04 May 2019 03:00:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment