Attention is currently required from: Kyösti Mälkki. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58700 )
Change subject: [WIP]cpu/x86/smm: Support PARALLEL_MP with SMM_ASEG ......................................................................
Patch Set 2:
(3 comments)
File src/cpu/x86/smm/smm_module_handler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139504): https://review.coreboot.org/c/coreboot/+/58700/comment/c4cee997_1ffc5452 PS2, Line 150: if (0) suspect code indent for conditional statements (8, 8)
File src/cpu/x86/smm/smm_module_loader.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139504): https://review.coreboot.org/c/coreboot/+/58700/comment/39e45c73_b5b6aac0 PS2, Line 440: static int smm_load_module_aseg(const uintptr_t smram_base, const size_t smram_size, struct smm_loader_params *params); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139504): https://review.coreboot.org/c/coreboot/+/58700/comment/34d93ddb_9586b3b3 PS2, Line 620: static int smm_load_module_aseg(const uintptr_t smram_base, const size_t smram_size, struct smm_loader_params *params) line over 96 characters