Attention is currently required from: Elyes Haouas, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Julius Werner, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Rishika Raj, Subrata Banik, Tarun, Werner Zeh, Yu-Ping Wu.
Angel Pons has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84152?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: tree: Drop unnecessary "true/false" comments
......................................................................
Patch Set 1:
(3 comments)
File src/soc/intel/jasperlake/chip.h:
https://review.coreboot.org/c/coreboot/+/84152/comment/ab4e39f7_6a55b674?usp... :
PS1, Line 111: Rank Margin Tool
I would keep this part
https://review.coreboot.org/c/coreboot/+/84152/comment/06214ee8_4ed990b2?usp... :
PS1, Line 266: HDP
This should be HPD (Hot Plug Detect). Fixing this would be out of scope for this change, though
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/84152/comment/39d50592_96d90cd2?usp... :
PS1, Line 290: /* Enable C6 DRAM */
: uint8_t enable_c6dram;
For another patch: this should also be a `bool`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84152?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5cd04972936c14d92295915fad65c7a45a8108d9
Gerrit-Change-Number: 84152
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 31 Aug 2024 08:01:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No