Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31979 )
Change subject: soc/nvidia/tegra{124,210}: Use 'halt()' already defined in <halt.h> ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/31979/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31979/1//COMMIT_MSG@7 PS1, Line 7: Use 'halt()' already defined in <halt.h> rather, `Drop local definition of halt()`
https://review.coreboot.org/#/c/31979/1//COMMIT_MSG@9 PS1, Line 9: This fix the error introduced in Change-Id: Ie7afe77 : : tegra_lp0_resume.c:431:40: error: static declaration of 'halt' follows non-static declaration : static __always_inline void __noreturn halt(void) : ^~~~ : In file included from tegra_lp0_resume.c:17: : ../../../../include/halt.h:26:17: note: previous declaration of 'halt' was here : void __noreturn halt(void); : ^~~~ : Please wrap this up, a single sentence should suffice, e.g.
Commit 74aa99a (src: Drop unused '#include <halt.h>') accidentally added redundant definitons of halt(), choose the generic one over the local.