[coreboot-gerrit] New patch to review for coreboot: 45735d8 lib/coreboot_table: set type and size of framebuffer tag after fill_lb_framebuffer

[Vladimir Serbinenko]

Vladimir Serbinenko ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4263

-gerrit

commit 45735d818e4b971a3e4952b6a8f149e494d0d2ab
Author: Vladimir Serbinenko 
Date:   Sat Nov 23 14:46:34 2013 +0100

lib/coreboot_table: set type and size of framebuffer tag after fill_lb_framebuffer

When testing Ron's patch on qemu I found out that fill_lb_framebuffer
    overwrites size and tag fields. We need either to fix/check all
    fill_lb_framebuffer implementations or write tag/size after fill_lb_framebuffer.
    I prefer later as it's more robust.

Change-Id: I98f5bac14f65fb4d990cb21426d402b27f2e8a48
    Signed-off-by: Vladimir Serbinenko 
---
 src/lib/coreboot_table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index e5729ba..a0a806d 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -177,9 +177,9 @@ static void lb_framebuffer(struct lb_header *header)
    	return;
    struct lb_framebuffer *framebuffer;
    framebuffer = (struct lb_framebuffer *)lb_new_record(header);
+	fill_lb_framebuffer(framebuffer);
    framebuffer->tag = LB_TAG_FRAMEBUFFER;
    framebuffer->size = sizeof(*framebuffer);
-	fill_lb_framebuffer(framebuffer);
 #endif
 }