[coreboot-gerrit] Change in coreboot[master]: drivers/ipmi: make IPMI KCS status and command register offset config...

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34835 )

Change subject: drivers/ipmi: make IPMI KCS status and command register offset configurable
......................................................................

Patch Set 2: Code-Review-1

(2 comments)

https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig 
File src/drivers/ipmi/Kconfig:

https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@5 
PS2, Line 5: choice
why is it user configurable?
Isn't that board/BMC specific?

https://review.coreboot.org/c/coreboot/+/34835/2/src/drivers/ipmi/Kconfig@15 
PS2, Line 15: 	bool "IPMI KCS register address offset 2 (WORD)"
that's not part of the spec.
It says:
"either on byte, 32-bit, or 16-byte boundaries"