Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44534 )
Change subject: soc/amd/common: add gpio subsystem event reporting ......................................................................
Patch Set 5: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/44534/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/44534/4/src/soc/amd/common/block/gp... PS4, Line 328: (1U << i) nit: BIT(i)
https://review.coreboot.org/c/coreboot/+/44534/5/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/44534/5/src/soc/amd/common/block/gp... PS5, Line 352: control_switch Just a note: This isn't really used anywhere except for printing below. Did you intend to check GPIO_WAKE_EN before inspecting the wake stat bits?