[coreboot-gerrit] Change in coreboot[master]: mb/google/brya/variants/crota: set up gpio

[Terry Chen (Code Review)]

Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Nick Vaccaro, Zhuohao Lee, YH Lin.
Terry Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62854 )

Change subject: mb/google/brya/variants/crota: set up gpio
......................................................................

Patch Set 8:

(2 comments)

File src/mainboard/google/brya/variants/crota/gpio.c:

https://review.coreboot.org/c/coreboot/+/62854/comment/4f01ddfa_f5d15426 
PS7, Line 49: /* E22 : DDPA_CTRLCLK ==> USB_C0_AUX_DC_STRAP_P */
            : 	PAD_CFG_NF(GPP_E22, NONE, DEEP, NF6),
> Is this supposed to be an AUX DC bias GPIO?

Yes, we found this pin set DY in PCB, so we set NC for this pin.

https://review.coreboot.org/c/coreboot/+/62854/comment/a07c5064_32fb5aa8 
PS7, Line 143: 	/* A12 : SATAXPCIE1 ==> EN_PPVAR_WWAN (set here for correct power sequencing) */
             : 	PAD_CFG_GPO(GPP_A12, 1, DEEP),
> is this the 850-GL ? please follow redrix for guidelines implementing the WWAN power sequencing

Yes, we follow redrix for the WWAN power sequencing. Thanks.