Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik, Weimin Wu.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81636?usp=email )
Change subject: mb/google/nissa/var/anraggar: Delay to deassert RST pin for TCHSCR
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81636/comment/8b044ae4_21b47ca8 :
PS3, Line 7: Delay to deassert RST pin for TCHSCR
Please use a verb in imperative mood. Either […]
Since it is configuring both RST and EN pin for touchscreen, may be
"Configure touchscreen related GPIOs" ?
https://review.coreboot.org/c/coreboot/+/81636/comment/eecf1cbf_c10373d2 :
PS3, Line 15: touchscreen function workable
may be "Build, Boot anraggar board and check touchscreen working" ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81636?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4bd17ecf8ffbe6ca8791fa1bc4577f4dfb4ea8e8
Gerrit-Change-Number: 81636
Gerrit-PatchSet: 3
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Thu, 04 Apr 2024 12:13:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment