[coreboot-gerrit] Change in coreboot[master]: soc/intel/alderlake: Add Acoustic noise mitigation UPDs

[Wisley Chen (Code Review)]

Attention is currently required from: Chen Wisley, Tim Wawrzynczak, Patrick Rudolph.
Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58944 )

Change subject: soc/intel/alderlake: Add Acoustic noise mitigation UPDs
......................................................................

Patch Set 5:

(3 comments)

File src/soc/intel/alderlake/chip.h:

https://review.coreboot.org/c/coreboot/+/58944/comment/752041c1_6d7cd0ef 
PS4, Line 546: *
             : 	 * Enable or Disable Acoustic Noise Mitigation feature
             : 	 */
> nit: single-line comment will work here

Done

https://review.coreboot.org/c/coreboot/+/58944/comment/15f9d9a2_b2e043c3 
PS4, Line 550: /*
             : 	 * Disable Fast Slew Rate for Deep Package C States for VR domains
             : 	 */
> nit: single-line comment will work here

Done

File src/soc/intel/alderlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/58944/comment/dfa80b21_0dc03f96 
PS4, Line 746: for (int i = 0; i < NUM_VR_DOMAINS; i++) {
             : 		s_cfg->FastPkgCRampDisable[i] = config->FastPkgCRampDisable[i];
             : 		s_cfg->SlowSlewRate[i] = config->SlowSlewRate[i];
             : 	}
> This should probably be guarded by `if (s_cfg->AcousticNoiseMitigation) {`

Done