10 Feb
2021
10 Feb
'21
5:57 p.m.
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Michael Niewöhner, Karthik Ramasubramanian. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50442 )
Change subject: drivers/i2c/hid: Enforce level triggered IRQ mode ......................................................................
Patch Set 3:
(1 comment)
File src/drivers/i2c/hid/hid.c:
https://review.coreboot.org/c/coreboot/+/50442/comment/5039df27_83446411 PS3, Line 82: dev->enabled = 0;
Not sure what you mean with "and possibly set the trigger type back to LEVEL" […]
You can use BUG(). With CONFIG_FATAL_ASSERTS=y, a misconfigured devicetree will result in a boot failure.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50442
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3245a9de6e88cd83528823251083e62288192f0d
Gerrit-Change-Number: 50442
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Wed, 10 Feb 2021 17:57:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment