Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34806 )
Change subject: arch/x86: Obsolete CACHE_AS_RAM config
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34806/1/src/cpu/x86/Makefile.inc
File src/cpu/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34806/1/src/cpu/x86/Makefile.inc@3
PS1, Line 3: y
romstage-$(CONFIG_CAR_GLOBAL_MIGRATION) += car.c […]
File has following so I thought guard is required:
ROMSTAGE_CBMEM_INIT_HOOK(car_migrate_variables)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34806
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65fa6b3ce8a86781724bbf08f5eadee4112667c4
Gerrit-Change-Number: 34806
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 09 Aug 2019 11:52:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment