[coreboot-gerrit] [S] Change in coreboot[main]: soc/mt6366: Work around GCC LTO build

[Arthur Heymans (Code Review)]

Attention is currently required from: Cliff Huang, Elyes Haouas, Hung-Te Lin, Julius Werner, Jérémy Compostella, Lance Zhao, Tim Wawrzynczak, Yidi Lin, Yu-Ping Wu.

Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84208?usp=email )

Change subject: soc/mt6366: Work around GCC LTO build
......................................................................

Patch Set 9:

(1 comment)

File src/soc/mediatek/mt8186/mt6366.c:

https://review.coreboot.org/c/coreboot/+/84208/comment/5098bb9d_da1a7bc0?usp... :
PS8, Line 10: #define NO_BUILDTIME_ASSERT
> > I still feel like that's a property of a few specific functions that happen to be grouped in this  […]

I'm wondering if a global disabling of this __build_time_assert with GCC + LTO makes more sense. Dealing with compiler false positives on a case by case basis (be it file or individual assert) is a big burden. A developer that is unaware of this might spend too much time on this to figure out that it's actually a compiler bug. CI also builds with clang which seems to have less of these 'unused code' LTO bugs.