Attention is currently required from: Nico Huber, Subrata Banik, Christian Walter, Sridhar Siricilla, Meera Ravindranath, Angel Pons.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61528 )
Change subject: mb/intel/adlrvp: Fix vbt loading error
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61528/comment/ded19baa_24b758e7
PS4, Line 15: VBTs for different RVP boards; while we only need 1 vbt for generic
Why aren't the files added to the tree? In case somebody wants to […]
Yeah agreed, using site-local is more proper way. we can merge this in for generic use case while chrome setup should use site-local instead. Thanks for the review Nico :)
Patchset:
PS1:
Hi Meera may I know do you stitch different vbt together and integrate in coreboot?
Close this as Maulik has replied.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61528
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f6f9554b75f4d62198aac9938e65c71c3e7cee9
Gerrit-Change-Number: 61528
Gerrit-PatchSet: 4
Gerrit-Owner: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 09 Feb 2022 12:03:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Meera Ravindranath
meera.ravindranath@intel.com
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-MessageType: comment