Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48220 )
Change subject: soc/amd: move smi_util to common block
......................................................................
Patch Set 1:
We need to check the specs anyway, so since it's moving to common it's probably a good time to do it. I think we'll be OK but I want to make sure we use the right amount of caution.
Yeah, i'll verify it tomorrow; only had a brief look at it today, but didn't spot any difference that would affect the code that gets moved to common
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48220
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f930287840bf7aa958f19786c7f1146c683c93e
Gerrit-Change-Number: 48220
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 23:32:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment