Aaron Durbin (adurbin@google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4904
-gerrit
commit ddf1fa83b79b165c1f82fed05eee947f7d31d407 Author: Aaron Durbin adurbin@chromium.org Date: Mon Oct 28 11:20:35 2013 -0500
baytrail: initialize chromeos EC if present in romstage
The EC needs to be initialized early in romstage. Therefore perform the call after console has been initialized in order to view any messages that the code may spit out.
BUG=chrome-os-partner:23387 BRANCH=None TEST=Built and booted with recovery mode and EC in RW. Noted that system reboots the EC.
Change-Id: I35aa3ea4aa3dbd9bd806b6498e227f45ceebd7a1 Signed-off-by: Aaron Durbin adurbin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/174713 Reviewed-by: Duncan Laurie dlaurie@chromium.org --- src/soc/intel/baytrail/romstage/romstage.c | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/src/soc/intel/baytrail/romstage/romstage.c b/src/soc/intel/baytrail/romstage/romstage.c index 10028ca..e833dbd 100644 --- a/src/soc/intel/baytrail/romstage/romstage.c +++ b/src/soc/intel/baytrail/romstage/romstage.c @@ -25,6 +25,9 @@ #include <console/console.h> #include <cbmem.h> #include <cpu/x86/mtrr.h> +#if CONFIG_EC_GOOGLE_CHROMEEC +#include <ec/google/chromeec/ec.h> +#endif #include <ramstage_cache.h> #include <ramstage_cache.h> #include <romstage_handoff.h> @@ -126,6 +129,11 @@ void * asmlinkage romstage_main(unsigned long bist,
gfx_init();
+#if CONFIG_EC_GOOGLE_CHROMEEC + /* Ensure the EC is in the right mode for recovery */ + google_chromeec_early_init(); +#endif + /* Call into mainboard. */ mainboard_romstage_entry(&rp);