Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71690 )
Change subject: mb/google/nissa/var/craask: remove SAR UNUSED fw_config ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/craask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/71690/comment/cb7de06c_8bcc9f1e PS2, Line 23: field WIFI_SAR_ID 13 15 : option ID_0 0 : end
So get rid of the option and just hardcode it to option ID_0?
The field is mostly to reserve space in fw_config in case multiple SAR tables are needed in the future. Yes we could hardcode it for now then add the field later if needed, but I think adding it now is fine too.
Yeah, value 7 wasn't used, because you can't get a 7 with just 2 bits.
It's 3 bits, the start and end bits are both inclusive.
Why was that even added?
There's a craask SKU which uses Intel wifi but does not need a SAR table, so UNUSED was meant to support that. But it turns out it's fine to use the same SAR table used for other SKUs on that SKU too, even though it's not strictly necessary. So we decided to do that to simplify things.