[coreboot-gerrit] Change in coreboot[master]: soc/intel/basecode: Add support for updating ucode loaded via FIT

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27369 )

Change subject: soc/intel/basecode: Add support for updating ucode loaded via FIT
......................................................................

Patch Set 70:

(3 comments)

https://review.coreboot.org/c/coreboot/+/27369/70/Documentation/soc/intel/uc... 
File Documentation/soc/intel/ucode_update/microcode_update_model.md:

PS70: 
I haven't got a chance to go through the doc and the changes again. I need to think through the flows and also the impact on hardware changes. Since this is not targeted for TGL, I would appreciate if we can hold on pushing this in for some time (Probably end of this month is earliest I can get to this).

https://review.coreboot.org/c/coreboot/+/27369/70/src/soc/intel/common/basec... 
File src/soc/intel/common/basecode/fw_update/ucode_update.c:

https://review.coreboot.org/c/coreboot/+/27369/70/src/soc/intel/common/basec... 
PS70, Line 131: 0x32
This needs to be added to vboot library first.

https://review.coreboot.org/c/coreboot/+/27369/70/src/soc/intel/common/basec... 
PS70, Line 264: BS_PRE_DEVICE
Why is this stage chosen for ucode update? CSE update is moving to romstage. I think this should be performed as early as possible (at least along with CSE update in romstage).