build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46878 )
Change subject: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver ......................................................................
Patch Set 10:
(6 comments)
https://review.coreboot.org/c/coreboot/+/46878/10/src/soc/mediatek/mt8192/pm... File src/soc/mediatek/mt8192/pmif.c:
https://review.coreboot.org/c/coreboot/+/46878/10/src/soc/mediatek/mt8192/pm... PS10, Line 310: /*srclken dissable, dcxo0,1 enable*/ 'dissable' may be misspelled - perhaps 'disable'?
https://review.coreboot.org/c/coreboot/+/46878/10/src/soc/mediatek/mt8192/pm... PS10, Line 333: void pmwrap_interface_init(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/46878/10/src/soc/mediatek/mt8192/sr... File src/soc/mediatek/mt8192/srclken_rc.c:
https://review.coreboot.org/c/coreboot/+/46878/10/src/soc/mediatek/mt8192/sr... PS10, Line 121: static void rc_dump_reg_info(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/46878/10/src/soc/mediatek/mt8192/sr... PS10, Line 166: << DCXO_STABLE_PRD_SHFT) ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/46878/10/src/soc/mediatek/mt8192/sr... PS10, Line 226: static void rc_init_subsys_hw_mode(void){ open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/46878/10/src/soc/mediatek/mt8192/sr... PS10, Line 236: static void rc_init_subsys_lpm(void){ open brace '{' following function definitions go on the next line