[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/gpio: Port gpio code from Apollolake ...

[Hannah Williams (Code Review)]

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19759 )

Change subject: soc/intel/common/block/gpio: Port gpio code from Apollolake to common
......................................................................

Patch Set 20:

(3 comments)

https://review.coreboot.org/#/c/19759/15/src/soc/intel/common/block/gpio/gpi...
File src/soc/intel/common/block/gpio/gpio.c:

PS15, Line 68: GPIO_MAX_NUM_PER_GROUP
> This is the 'group' within the community.  But you are saying that the gpio

I'll add this as a field inside the community.

https://review.coreboot.org/#/c/19759/20/src/soc/intel/common/block/gpio/gpi...
File src/soc/intel/common/block/gpio/gpio.c:

PS20, Line 54: 32
> Shouldn't this be GPIO_MAX_NUM_PER_GROUP?

I'll move this as a field inside const struct pad_community - because each group or community can also have a different max number of pins per group

PS20, Line 80: soc_gpio_configure_itss
> Why does this have soc_ in its name?

will fix