Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46458 )
Change subject: tests: Add lib/imd_cbmem-test test case
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46458/3/tests/lib/imd_cbmem-test.c
File tests/lib/imd_cbmem-test.c:
https://review.coreboot.org/c/coreboot/+/46458/3/tests/lib/imd_cbmem-test.c@...
PS3, Line 191: 0x10
Done
I see the comment on the earlier test case, but the IDs are still sequential for every test. Please change a couple of the test cases to use non-sequential numbers to prove that it works. Also, does id1 have to be less than id2? If not, change at least one test case so that id1 > id2.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46458
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie893b5e8fc91c230ff96a14146085de16d78b1c1
Gerrit-Change-Number: 46458
Gerrit-PatchSet: 7
Gerrit-Owner: Name of user not set #1003143
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 10 Nov 2020 17:32:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Name of user not set #1003143
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment