Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34255 )
Change subject: intel/fsp_baytrail: Avoid preprocessor with HAVE_SMI_HANDLER
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34255/2/src/soc/intel/fsp_baytrail/...
File src/soc/intel/fsp_baytrail/gpio.c:
https://review.coreboot.org/c/coreboot/+/34255/2/src/soc/intel/fsp_baytrail/...
PS2, Line 195: /* FIXME: SCI interrupts should be routed regardlessy. */
Maybe move this check inside lines 201 and 207?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34255
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ada4b2a16490a15d8036a9425c4f768f7b8f218
Gerrit-Change-Number: 34255
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Jul 2019 17:59:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment