Attention is currently required from: Arthur Heymans.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83407?usp=email )
Change subject: emulation/qemu-q35: Move QEMU specific macros to "q35.h" ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
why? do you want to use those macros some place else?
Those macros `#define SMRAMC 0x9d
#define G_SMRAME (1 << 3) #define D_LCK (1 << 4) #define D_CLS (1 << 5) #define D_OPEN (1 << 6) #define ESMRAMC 0x9e #define T_EN (1 << 0) #define TSEG_SZ_MASK (3 << 1) #define H_SMRAME (1 << 7)` are already defined in "q35.h" file. and "src/mainboard/emulation/qemu-q35/memmap.c" file includes "q35.h", so why not remove macros redefine and move remaining macros to "q35.h"