Attention is currently required from: Felix Singer, Wonkyu Kim, Benjamin Doron, Ravishankar Sarawadi, Stefan Reinauer, Angel Pons, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 )
Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs ......................................................................
Patch Set 4:
(17 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56171/comment/79667a05_290d8004 PS4, Line 9: Tiger Lake
nit: Tiger Lake LP
Done
Patchset:
PS4:
Right, I may use OpenBoardPackage
Done
File util/inteltool/gpio_names/tigerlake.h:
PS4:
If the other files also lack the license, I would put a separate patch to fill all missing license h […]
Ack
https://review.coreboot.org/c/coreboot/+/56171/comment/efc257af_33a0f4bf PS4, Line 70:
nit: drop blank line
Done
https://review.coreboot.org/c/coreboot/+/56171/comment/b47b13f7_1d88323f PS4, Line 135: };
missing GSPI2_CLK_LOOPBK
Done
https://review.coreboot.org/c/coreboot/+/56171/comment/114730cd_7aa4bccb PS4, Line 169: };
24 is GPPE_CLK_LOOPBK, "n/a", "THC0_CLK_LOOPBACK"
Done
https://review.coreboot.org/c/coreboot/+/56171/comment/46173f77_f0d7e33e PS4, Line 179: const char *const tigerlake_pch_lp_fe_hole_names[] = {
this is the HVMOS group, compare util/inteltool/gpio_names/cannonlake_lp. […]
Done
https://review.coreboot.org/c/coreboot/+/56171/comment/e11f1864_fa227c30 PS4, Line 221: };
24 is GPPF_CLK_LOOPBK, "n/a", "THC1_CLK_LOOPBACK"
Done
https://review.coreboot.org/c/coreboot/+/56171/comment/d47aeb65_74668459 PS4, Line 336: "Reserved",
Yes, they are. […]
Added all GPP_U pins according to OpenBoardPackage
https://review.coreboot.org/c/coreboot/+/56171/comment/b9f772de_801c3ce0 PS4, Line 361: };
These are GPD12+??
Done
https://review.coreboot.org/c/coreboot/+/56171/comment/5abf762d_1ab95f6c PS4, Line 535: 3
I think this is actually 5? GPP_C was dumping strangely and it mismatches the pad_count.
Yes, copy pasta error
https://review.coreboot.org/c/coreboot/+/56171/comment/431d31e1_c8a13da5 PS4, Line 575: tigerlake_pch_h_group_e_names
"GPP_E0/SATAXPCIE0/SATAGP0" is missing.
Done
https://review.coreboot.org/c/coreboot/+/56171/comment/664c22d0_a314f896 PS4, Line 753: GPP_J
GPP_K
Done
https://review.coreboot.org/c/coreboot/+/56171/comment/89beaa95_25f93989 PS4, Line 759: tigerlake_pch_h_group_r_names
"GPP_R0/HDA_BCLK/I2S0_SCLK/n_a/HDACPU_BCLK," "GPP_R1/HDA_SYNC/I2S0_SFRM/n_a/n_a" and "GPP_R2/HDA_SDO […]
Done
https://review.coreboot.org/c/coreboot/+/56171/comment/f32dc808_4ea594bd PS4, Line 777:
nit: drop blank line
Done
https://review.coreboot.org/c/coreboot/+/56171/comment/9d302334_7746a85d PS4, Line 901: tigerlake_pch_h_communities
Will check with other sources. […]
Done
File util/inteltool/pcr.c:
https://review.coreboot.org/c/coreboot/+/56171/comment/6c290ea8_6623ae3c PS4, Line 108: case PCI_DEVICE_ID_INTEL_Q570: : case PCI_DEVICE_ID_INTEL_Z590: : case PCI_DEVICE_ID_INTEL_H570: : case PCI_DEVICE_ID_INTEL_B560: : case PCI_DEVICE_ID_INTEL_H510: : case PCI_DEVICE_ID_INTEL_WM590: : case PCI_DEVICE_ID_INTEL_QM580: : case PCI_DEVICE_ID_INTEL_HM570: : case PCI_DEVICE_ID_INTEL_C252: : case PCI_DEVICE_ID_INTEL_C256: : case PCI_DEVICE_ID_INTEL_W580:
Okay. We may pray that nobody changes the default sideband BAR...
Done