[coreboot-gerrit] [XS] Change in coreboot[main]: src/device/Kconfig: Enable eSOL config with libgfx and uGOP

[Angel Pons (Code Review)]

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Subrata Banik.

Angel Pons has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83705?usp=email )

Change subject: src/device/Kconfig: Enable eSOL config with libgfx and uGOP
......................................................................

Patch Set 9: Code-Review+1

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83705/comment/eb6486b3_1e21893f?usp... :
PS9, Line 7: src/device
vc/google/chromeos

File src/vendorcode/google/chromeos/Kconfig:

https://review.coreboot.org/c/coreboot/+/83705/comment/2a69937b_7d3fb3ce?usp... :
PS6, Line 105: menu "CHROMEOS_ESOL"
> we don't need this

Gone

https://review.coreboot.org/c/coreboot/+/83705/comment/4016df32_cdafdd37?usp... :
PS6, Line 114: endmenu
> same

Gone

File src/vendorcode/google/chromeos/Kconfig:

https://review.coreboot.org/c/coreboot/+/83705/comment/28a9611f_514ea3e4?usp... :
PS9, Line 106: bool
             : 	default y if FSP_UGOP_EARLY_SIGN_OF_LIFE || MAINBOARD_HAS_EARLY_LIBGFXINIT
             : 	default n
nit: I think this is a less verbose equivalent:

```suggestion
    def_bool FSP_UGOP_EARLY_SIGN_OF_LIFE || MAINBOARD_HAS_EARLY_LIBGFXINIT
```

https://review.coreboot.org/c/coreboot/+/83705/comment/f322afdd_4bf3b17e?usp... :
PS9, Line 111: 
nit: drop blank line