Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36079 )
Change subject: mb/supermicro/x11-lga1151-series: Fix SLP assertion width ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... PS1, Line 101: # Enabling SLP_S3#, SLP_S4#, SLP_SUS and SLP_A Stretch : register "PmConfigSlpS3MinAssert" = "SLP_S3_MIN_ASSERT_50MS" : register "PmConfigSlpS4MinAssert" = "SLP_S4_MIN_ASSERT_4S" : register "PmConfigSlpSusMinAssert" = "SLP_SUS_MIN_ASSERT_4S" : register "PmConfigSlpAMinAssert" = "SLP_A_MIN_ASSERT_2S" at least on x11ssm, all these values match vendor settings; can you share a inteltool dump with CB:35189, please? maybe those values differ for x11ssh-tf. then we'd need to move those settings to the variants overridetree
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... PS1, Line 7: register "s0ix_enable" = "0" already defaults to "0", not needed
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... PS1, Line 107: PmConfigPwrBtnOverridePeriod not needed. a) this has nothing to do with Slp but sets the time you need to press the power button to do a global reset and b) this already defaults to 0, which is 4s.
https://review.coreboot.org/c/coreboot/+/36079/1/src/mainboard/supermicro/x1... PS1, Line 108: PmConfigPwrCycDur why is this needed? this is PWR_CYC_DUR; vendor sets default (4-5 secs = value 0) on x11ssm