Maccraft123 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board
......................................................................
Patch Set 40:
(2 comments)
Patch Set 40:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35864/40/src/mainboard/lenovo/t60/g...
File src/mainboard/lenovo/t60/gpio.c:
https://review.coreboot.org/c/coreboot/+/35864/40/src/mainboard/lenovo/t60/g...
PS40, Line 88: .gpio36 = GPIO_DIR_INPUT,
why change?
oops
https://review.coreboot.org/c/coreboot/+/35864/40/src/mainboard/lenovo/t60/g...
PS40, Line 30: .gpio19 = GPIO_MODE_GPIO, /* GBE_RS# */
The comments, and format changes could be added in a separate commit to make the diff smaller and re […]
These comments only add what gpio does what if it isn't native function. It is not any "code" commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd9208a5eafd228f8eedbc8fb4f4eb9ed1932a14
Gerrit-Change-Number: 35864
Gerrit-PatchSet: 40
Gerrit-Owner: Maccraft123
maccraft123mc@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Maccraft123
maccraft123mc@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Comment-Date: Sun, 20 Oct 2019 16:08:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment