Attention is currently required from: Felix Singer, Martin Roth, Paul Menzel, Tim Wawrzynczak. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62796 )
Change subject: x86/smbios_defaults: Set default system manufacturer for ChromeOS devices ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62796/comment/4b7411c2_a7970602 PS1, Line 9: Currently, many Linux drivers use DMI quirks to identify ChromeOS devices and : handle them accordingly: namely they look for the SMBIOS system manufactuer : to be "GOOGLE" or "Google", and the bios-vendor to be coreboot. Historically : this was consistently the case, but recent model ChromeOS devices allow the : OEM to set the mainboard manufacturer, which is also the default system : manufacturer. This breaks many DMI quirks, notably ones used by SOF (sound : open firmware) for audio.
Please reflow for 72 characters per line.
Done
https://review.coreboot.org/c/coreboot/+/62796/comment/5479c639_20835a6e PS1, Line 14: This breaks many DMI quirks, notably ones used by SOF (sound : open firmware) for audio.
Do you know of the Chromium OS Linux kernel commit making this work for Chromium OS?
there is none, as the SoF code backported to the ChromeOS kernel doesn't rely on DMI quirks
File src/arch/x86/smbios_defaults.c:
https://review.coreboot.org/c/coreboot/+/62796/comment/2e27ef46_4eb8e4d3 PS1, Line 119: return "Google";
I would like to avoid vendor specific configurations in common code. […]
I think that will work, will give it a look
https://review.coreboot.org/c/coreboot/+/62796/comment/ae45f9ff_e721dbe3 PS1, Line 121: return smbios_mainboard_manufacturer();
You could you the ternary operator, use the if statement, and also add a log message, that it’s over […]
I'm unclear what exactly you're looking for here