[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Configure IPU based on devicetree

[John Zhao (Code Review)]

John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44627 )

Change subject: soc/intel/tigerlake: Configure IPU based on devicetree
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44627/2/src/soc/intel/tigerlake/rom... 
File src/soc/intel/tigerlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/44627/2/src/soc/intel/tigerlake/rom... 
PS2, Line 171: 		m_cfg->VtdIpuEnable = 0x1;
             : 		m_cfg->VtdBaseAddress[1] = IPUVT_BASE_ADDRESS;
> John can you please confirm if check is needed?

Yes, please consider to move IPU configuration before the VT-d setting. Then add check for both of GPU and IPU like:
if (m_cfg->InternalGfx) {
  m_cfg->VtdIgdEnable = 0x1;
  m_cfg->VtdBaseAddress[0] = GFXVT_BASE_ADDRESS;
}

if (m_cfg->SaIpuEnable) {
  m_cfg->VtdIpuEnable = 0x1;
  m_cfg->VtdBaseAddress[1] = IPUVT_BASE_ADDRESS;
}