Attention is currently required from: Paul Menzel, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56339 )
Change subject: asrock/e3c246d4i: Add Intel Coffee Lake board
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/asrock/e3c246d4i/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/56339/comment/2c1104b9_03831f64
PS4, Line 107: device pci 1b.0 on # PCI Express Port 17
What is this used for? Avoiding coalescing? […]
Right, you'd have to tell FSP that a RP is implemented as a slot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56339
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66e168c8af5de9862b0724fa397ecd709843af1a
Gerrit-Change-Number: 56339
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 15 Jul 2021 14:33:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment