Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )
Change subject: security/vboot: Add vboot callbacks to support EC software sync
......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36208/15/src/security/vboot/Kconfig
File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/36208/15/src/security/vboot/Kconfig...
PS15, Line 236: is already
: currently performed later in the boot flow.
will be performed later in the boot flow if it is disabled here.
https://review.coreboot.org/c/coreboot/+/36208/3/src/security/vboot/ec_sync....
File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/36208/3/src/security/vboot/ec_sync....
PS3, Line 14: #include <2ec_sync.h>
Done
And also it should be ordered alphabetically -- i.e. after vb2_constants.h.
Also, since we're adding vb2_api.h, we don't need to include vb2_constants.h anymore.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b1458a45ab3ed5623af50f78036c4f88461b226
Gerrit-Change-Number: 36208
Gerrit-PatchSet: 15
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Nov 2019 10:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment