Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62606 )
Change subject: ec/starlabs: Store the correct value for KLBE when suspending ......................................................................
ec/starlabs: Store the correct value for KLBE when suspending
The current code will read the raw value from the EC, which doesn't match the respective setting in CMOS.
Switch argument will store the correct value.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: Ic2a83df9a270de6d7bab295e732a6c13accbe17c --- M src/ec/starlabs/merlin/acpi/suspend.asl 1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/62606/1
diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl index e33201b..453e153 100644 --- a/src/ec/starlabs/merlin/acpi/suspend.asl +++ b/src/ec/starlabs/merlin/acpi/suspend.asl @@ -51,8 +51,19 @@ } }
- _SB.PCI0.LPCB.KLBC = - _SB.PCI0.LPCB.EC.ECRD (RefOf (_SB.PCI0.LPCB.EC.KLBE)) + Switch (_SB.PCI0.LPCB.EC.ECRD (RefOf (_SB.PCI0.LPCB.EC.KLBE))) + { + // 0x00 == Disabled == 0x00 + // 0xdd == Enabled == 0x01 + Case (0x00) + { + _SB.PCI0.LPCB.KLBC = 0x00 + ) + Case (0xdd) + { + _SB.PCI0.LPCB.KLBC = 0x01 + } + } }
_SB.PCI0.LPCB.EC.OSFG = 0x00