Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38214 )
Change subject: asus/am1i-a: fix the VGA-related PCI resource allocation problems ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38214/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38214/3//COMMIT_MSG@11 PS3, Line 11: It does not bring any downsides if there is no discrete VGA adapter.
Please wrap the lines after 75 characters.
Done.
https://review.coreboot.org/c/coreboot/+/38214/3//COMMIT_MSG@15 PS3, Line 15: Otherwise there could be i.e. a "Fatal error during GPU init".
Maybe show the BARs reported by Linux (or coreboot) before and after.
A bit difficult to compare, considering I can't reach a Linux console if there's such an error. :( I tried to compare the coreboot logs using an EHCI dongle, some addresses are lower by 0x10000000 as expected: i.e. add_uma_resource_below_tolm memory_start: 0xc0000000 if no fix, 0xb0000000 with fix; DOMAIN: 0000 resource base c0000000 if no fix, 0xb0000000 with fix; etc. However, despite a console level SPEW 8 I don't see any added error messages and many PCI parts print the same info; I'm a bit lost to be honest.