[coreboot-gerrit] Change in ...coreboot[master]: vboot: copy data structures to CBMEM for downstream use

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31329 )

Change subject: vboot: copy data structures to CBMEM for downstream use
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/31329/3/src/security/vboot/common.c 
File src/security/vboot/common.c:

https://review.coreboot.org/#/c/31329/3/src/security/vboot/common.c@44 
PS3, Line 44: static uint8_t use_cbmem CAR_GLOBAL;
> We could also just simplify and get rid of the global altogether: […]

if vb2_wd is a local variable it's value is undefined. It'd need to be marked static. That's the equivalent of a compilation unit global -- just scoped to be accessed only within the function. In both cases the object would be placed in .bss w/o decoration or .car.global with CAR_GLOBAL decoration.