Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: soc/mediatek/mt8183: Run DRAM full calibration ......................................................................
Patch Set 50:
(6 comments)
Good refactoring!
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... PS50, Line 56: ", header->magic header.maigc = %#X (expected: %#x)\n", header->magic, DRAMC_PARAM_MAGIC);
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... PS50, Line 57: version print expected version as well
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... PS50, Line 58: .siz print expected size as well
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... PS50, Line 68: BIOS_NOTICE BIOS_WARNING
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... PS50, Line 75: BIOS_NOTICE BIOS_WARNING
https://review.coreboot.org/c/coreboot/+/35110/50/src/soc/mediatek/mt8183/me... PS50, Line 107: | &