[coreboot-gerrit] Change in coreboot[master]: mediatek/mt8192: add spmfw loader

[Nicolas Boichat (Code Review)]

Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )

Change subject: mediatek/mt8192: add spmfw loader
......................................................................

Patch Set 17:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46389/17/src/soc/mediatek/mt8192/sp... 
File src/soc/mediatek/mt8192/spm.c:

https://review.coreboot.org/c/coreboot/+/46389/17/src/soc/mediatek/mt8192/sp... 
PS17, Line 931: 
Please consider adding the assertions here:

https://review.coreboot.org/c/coreboot/+/47283/3/src/soc/mediatek/mt8192/spm...

https://review.coreboot.org/c/coreboot/+/46389/17/src/soc/mediatek/mt8192/sp... 
PS17, Line 945: 		write32(&mtk_spm->md32pcm_dma0_start, MD32PCM_DMA0_START_VAL);
Is it useful to add this:
write32(&mtk_spm->md32pcm_dma0_start, 0);

just before, just in case (unless the registers don't work this way...)